polkadot-parachain: add manual seal support
#5586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
R0-silent
serban300
force-pushed
the
polkadot-parachain-manual-seal
branch
from
d283731
to
bc89536
Compare
serban300
force-pushed
the
polkadot-parachain-manual-seal
branch
from
bc89536
to
0c8a994
Compare
kianenigma
reviewed
Sep 4, 2024
cumulus/polkadot-parachain/polkadot-parachain-lib/src/command.rs
Outdated
Show resolved
Hide resolved
kianenigma
reviewed
Sep 4, 2024
skunert
reviewed
Sep 10, 2024
cumulus/polkadot-parachain/polkadot-parachain-lib/src/common/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/common/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/command.rs
Outdated
Show resolved
Hide resolved
skunert
reviewed
Sep 25, 2024
cumulus/polkadot-parachain/polkadot-parachain-lib/src/nodes/manual_seal.rs
Outdated
Show resolved
Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/nodes/manual_seal.rs
Outdated
Show resolved
Hide resolved
cumulus/polkadot-parachain/polkadot-parachain-lib/src/nodes/manual_seal.rs
Show resolved
Hide resolved
kianenigma
reviewed
Oct 1, 2024
kianenigma
approved these changes
Oct 1, 2024
|
Final request: PR description also seems out of date wrt example 🙏 |
kianenigma
reviewed
Oct 2, 2024
Sorry, missed it. Done. |
Merged
via the queue into
paritytech:master
with commit Oct 2, 2024
3cf83ca
217 of 218 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Removing the shell node variant for the polkadot-parachain as discussed here: #5586 (comment) Resolves #5898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5026
This PR adds support for starting a dev node with manual seal consensus. This can be done by using the
--dev-block-timeargument . For example: